-
Notifications
You must be signed in to change notification settings - Fork 33
OCPBUGS-62173: Add TLS config observer to update opcon/catd #145
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
@tmshort: This pull request references Jira Issue OCPBUGS-62173, which is valid. The bug has been moved to the POST state. 3 validation(s) were run on this bug
No GitHub users were found matching the public email listed for the QA contact in Jira ([email protected]), skipping review request. The bug has been updated to refer to the pull request using the external bug tracker. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: tmshort The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@tmshort: This pull request references Jira Issue OCPBUGS-62173, which is valid. 3 validation(s) were run on this bug
No GitHub users were found matching the public email listed for the QA contact in Jira ([email protected]), skipping review request. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
/test openshift-e2e-aws |
95cfa2b
to
642bcb0
Compare
/retest-required |
Add an apiserver TLS config observer. This examines TLS config and copies the values into the .spec.observedConfig field of the olms.operator.openshift.io/cluster resource. This is then used to apply configuration to the operator-controller and catalogd. The configuration is applied to those deployments via: * --tls-custom-ciphers=X,Y,Z * --tls-custom-version=N * --tls-profile=custom In addition: * Move the deployment update hooks (proxy, TLS) into their own files * Add unit tests * Changed Apply()s to Patch()s when modifying olms to avoid overwrites * Update fieldManagers to avoid overwrites Signed-off-by: Todd Short <[email protected]> Co-Authored-By: Claude <[email protected]>
Which seems unrelated. After approvals, I will re-run it, but I may override it. |
@tmshort: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
/test openshift-e2e-aws-devpreview |
Add an apiserver TLS config observer. This examines TLS config and
copies the values into the .spec.observedConfig field of the
olms.operator.openshift.io/cluster resource. This is then used to
apply configuration to the operator-controller and catalogd.
The configuration is applied to those deployments via:
In addition:
Signed-off-by: Todd Short [email protected]
Co-Authored-By: Claude [email protected]